R4R: removed governance slashing #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
sunnya97
changed the title
sunnya97
force-pushed
the
sunny/remove-gov-slashing
branch
from
4f379c8
to
a0bbcde
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2395 +/- ##
===========================================
- Coverage 63.54% 63.12% -0.43%
===========================================
Files 120 120
Lines 7236 7224 -12
===========================================
- Hits 4598 4560 -38
- Misses 2326 2350 +24
- Partials 312 314 +2 |
|
Hrmm. An interesting consequence of this is that the the simulator will no longer catch a significant portion of the slashing bugs its been finding, until we fix #2320. This is because they were all being caught on governance slashing, and only execute after a slashing occurred. We'll have to do a bunch more work to now test our staking code, but thats nbd. I'll make a follow-up issue |
cwgoes
approved these changes
Sep 25, 2018
There was a problem hiding this comment.
utACK but waiting to merge for the moment (want to wait for simulation updates re @ValarDragon's comment)
|
Ref: #2396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2256
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: